[wp-trac] [WordPress Trac] #43218: PHPUnit 7.x support

[WordPress Trac]

#43218: PHPUnit 7.x support
------------------------------------------------+--------------------------
 Reporter:  ayeshrajans                         |       Owner:
                                                |  SergeyBiryukov
     Type:  defect (bug)                        |      Status:  accepted
 Priority:  normal                              |   Milestone:  5.1
Component:  Build/Test Tools                    |     Version:  trunk
 Severity:  normal                              |  Resolution:
 Keywords:  has-patch needs-docs needs-testing  |     Focuses:
------------------------------------------------+--------------------------
Changes (by desrosj):

 * keywords:  has-patch needs-refresh needs-docs => has-patch needs-docs
     needs-testing


Comment:

 [attachment:"43218.diff"] is a refreshed patch. It produces two weird
 failures, though. Investigating further, but it's possible I missed
 something in my refresh.

 On PHPUnit 7:


 {{{
 1) WP_Test_REST_Schema_Sanitization::test_type_string
 Failed asserting that two strings are equal.
 --- Expected
 +++ Actual
 @@ @@
 -'1.10'
 +'1.1'
 /home/travis/build/WordPress/wordpress-develop/tests/phpunit/tests/rest-
 api/rest-schema-sanitization.php:41
 }}}


 On PHPUnit 6:

 {{{
 1)
 Tests_Multisite_Site_Meta::test_site_meta_should_be_deleted_when_site_is_deleted
 Failed asserting that two strings are identical.
 --- Expected
 +++ Actual
 @@ @@
 -''
 +'bar'
 /home/travis/build/WordPress/wordpress-
 develop/tests/phpunit/tests/multisite/siteMeta.php:218
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/43218#comment:29>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform