[wp-trac] [WordPress Trac] #45928: Twenty Nineteen: Add a filter to the $primay_color variable

WordPress Trac noreply at wordpress.org
Sun Jan 13 20:00:58 UTC 2019


#45928: Twenty Nineteen: Add a filter to the $primay_color variable
-------------------------------------+---------------------
 Reporter:  allancole                |       Owner:  (none)
     Type:  enhancement              |      Status:  new
 Priority:  normal                   |   Milestone:  5.1.1
Component:  Bundled Theme            |     Version:
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |     Focuses:
-------------------------------------+---------------------

Comment (by LittleBigThing):

 Don't we need to filter the default primary color (hue) for a couple more
 instances?

 The default value of 199 is used:

 - to add the color palette to the editor
 (https://core.trac.wordpress.org/browser/trunk/src/wp-
 content/themes/twentynineteen/functions.php#L142)
 - in `twentynineteen_colors_css_wrap()`
 (https://core.trac.wordpress.org/browser/trunk/src/wp-
 content/themes/twentynineteen/functions.php#L273)
 - when adding the default customizer setting
 (https://core.trac.wordpress.org/browser/trunk/src/wp-
 content/themes/twentynineteen/inc/customizer.php#L64)
 - each time as a default to get the theme mod as `get_theme_mod(
 'primary_color_hue' , 199 )` when there is no custom hue selected yet
 - even in `js/customize-preview.js`

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/45928#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list