[wp-trac] [WordPress Trac] #45956: Upgrade WPCS to 1.2.1

[WordPress Trac]

#45956: Upgrade WPCS to 1.2.1
----------------------------+-------------------------------
 Reporter:  pento           |       Owner:  pento
     Type:  task (blessed)  |      Status:  assigned
 Priority:  normal          |   Milestone:  5.1
Component:  General         |     Version:
 Severity:  normal          |  Resolution:
 Keywords:                  |     Focuses:  coding-standards
----------------------------+-------------------------------
Description changed by pento:

Old description:

> By upgrading WPCS to 1.2.1:
>
> - `Generic.PHP.NoSilencedErrors.Discouraged` is replaced by
> `WordPress.PHP.NoSilencedErrors.Discouraged`, which whitelists 123
> instances of errors being appropriately silenced.
> - Autofix 191 violations of `Generic.WhiteSpace.ScopeIndent`.
> - Fix 6 false positives in
> `WordPress.WhiteSpace.PrecisionAlignment.Found`.
>
> By upgrading PHPCS to 3.4.1:
>
> - Fix 23 false positives in `Squiz.PHP.DisallowMultipleAssignments.Found`

New description:

 By upgrading WPCS to 1.2.1:

 - `Generic.PHP.NoSilencedErrors.Discouraged` is replaced by
 `WordPress.PHP.NoSilencedErrors.Discouraged`, which whitelists 123
 instances of errors being appropriately silenced.
 - Autofix 191 violations of `Generic.WhiteSpace.ScopeIndent`.
 - Fix 6 false positives in
 `WordPress.WhiteSpace.PrecisionAlignment.Found`.
 - The `allowMultipleArguments` property of
 `PEAR.Functions.FunctionCallSignature` defaults to `false`, so we can
 remove that custom setting from `phpcs.xml.dist`.

 By upgrading PHPCS to 3.4.1:

 - Fix 23 false positives in `Squiz.PHP.DisallowMultipleAssignments.Found`

--

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/45956#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform