[wp-trac] [WordPress Trac] #45934: Coding Standards: Manual Fixes

[WordPress Trac]

#45934: Coding Standards: Manual Fixes
----------------------------+-------------------------------
 Reporter:  pento           |       Owner:  pento
     Type:  task (blessed)  |      Status:  assigned
 Priority:  low             |   Milestone:  5.1
Component:  General         |     Version:
 Severity:  minor           |  Resolution:
 Keywords:                  |     Focuses:  coding-standards
----------------------------+-------------------------------

Comment (by pento):

 > why would the Gutenberg plugin not be expected to comply with the WP
 Coding Standards

 It should be, but these files are managed in the Gutenberg plugin: if they
 have code formatting issues, they need to be fixed in the Gutenberg repo.

 > Regarding Yoda conditions

 Yah, I agree that `WordPress/Generic.CodeAnalysis.AssignmentInCondition`
 should be moved into `Core`, violations should be fixed, and then Yoda
 conditions should be removed. There's some discussion on #42885 about Yoda
 conditions, too.

 Notably, the [https://make.wordpress.org/core/2018/12/18/proposed-
 revisions-to-javascript-coding-standards/ JS team are planning on removing
 guidance on Yoda conditions], I'm inclined to disallow Yoda conditions,
 rather than simply allow either style, though.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/45934#comment:15>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform