[wp-trac] [WordPress Trac] #44981: Make notice on Privacy Policy page to 'Check out our guide' dismissable
WordPress Trac
noreply at wordpress.org
Sat Jan 12 01:19:35 UTC 2019
#44981: Make notice on Privacy Policy page to 'Check out our guide' dismissable
-------------------------------------------------+-------------------------
Reporter: garrett-eclipse | Owner: garrett-
| eclipse
Type: enhancement | Status: assigned
Priority: normal | Milestone: Future
| Release
Component: Privacy | Version: 4.9.6
Severity: normal | Resolution:
Keywords: has-patch has-screenshots dev- | Focuses:
feedback needs-testing |
-------------------------------------------------+-------------------------
Comment (by garrett-eclipse):
Thanks for the feedback @pento I tend to agree would be nice to save the
dismissed state of the notice there.
I can definitely work on that functionality but am hoping for a little
direction if you don't mind.
To keep the notice dismissed I would be adding a flag either as a Cookie,
Session data or User Meta and am wondering if there's an existing standard
(maybe an example) for this in core?
As well whatever storage method is used I feel should get cleared when the
policy text has changed so as to re-introduce the guide link.
If I do that it would make sense to be done here along side the
`policy_text_changed_notice` notice which re-appears on the privacy.php
screen.
And by here I mean -
https://github.com/WordPress/WordPress/blob/51155f3989c29bbae5322b6cba58952a7c58b0ba
/wp-admin/includes/misc.php#L1428
I'm leaning towards using User Meta over Cookie/Session data as it
pertains across browsers/devices and is a more permanent dismissal but
would love your thoughts.
Thanks
--
Ticket URL: <https://core.trac.wordpress.org/ticket/44981#comment:12>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list