[wp-trac] [WordPress Trac] #45950: Twenty Nineteen: Fix social media icons to use the correct height & width attribute

WordPress Trac noreply at wordpress.org
Fri Jan 11 23:46:44 UTC 2019


#45950: Twenty Nineteen: Fix social media icons to use the correct height & width
attribute
--------------------------+-----------------------------
 Reporter:  crunnells     |      Owner:  (none)
     Type:  defect (bug)  |     Status:  new
 Priority:  normal        |  Milestone:  Awaiting Review
Component:  General       |    Version:  5.0.3
 Severity:  normal        |   Keywords:
  Focuses:                |
--------------------------+-----------------------------
 This comes from a PR in GitHub:
 https://github.com/WordPress/twentynineteen/pull/754

 The PR in question proposes to change social icon sizes to 26px, because
 of what _seems_ to be an erroneous setting in
 `twentynineteen_nav_menu_social_icons()`. I suggest removing the 26, since
 the CSS is set to show the icons at 32px, which overrides the 26px
 _anyway_.

 Maybe update the default from 24 to 32 as well?

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/45950>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list