[wp-trac] [WordPress Trac] #43304: Data type of deprecated parameter of load_plugin_textdomain function should be bool and not string
WordPress Trac
noreply at wordpress.org
Fri Jan 11 12:25:34 UTC 2019
#43304: Data type of deprecated parameter of load_plugin_textdomain function should
be bool and not string
-------------------------+-------------------------------------------------
Reporter: sudar | Owner: (none)
Type: enhancement | Status: new
Priority: low | Milestone: Future Release
Component: I18N | Version:
Severity: minor | Resolution:
Keywords: has-patch | Focuses: docs, administration, coding-
| standards
-------------------------+-------------------------------------------------
Changes (by swissspidy):
* priority: normal => low
* version: trunk =>
* type: defect (bug) => enhancement
* severity: normal => minor
* milestone: 5.1 => Future Release
Comment:
It's still possible to pass a string to `$deprecated`, so the docblock is
technically correct. It's just so that in WordPress we often use `false`
as a default value when we expect other data types otherwise.
If anything I'd annotate it as `string|false`, but I don't see it as a
pressing problem.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/43304#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list