[wp-trac] [WordPress Trac] #45934: Coding Standards: Manual Fixes

[WordPress Trac]

#45934: Coding Standards: Manual Fixes
------------------------------+----------------------
 Reporter:  pento             |      Owner:  pento
     Type:  task (blessed)    |     Status:  assigned
 Priority:  low               |  Milestone:  5.1
Component:  General           |    Version:
 Severity:  minor             |   Keywords:
  Focuses:  coding-standards  |
------------------------------+----------------------
 Here's the current output of `composer run lint`.
 {{{
 PHP CODE SNIFFER VIOLATION SOURCE SUMMARY
 ----------------------------------------------------------------------
 SOURCE                                                           COUNT
 ----------------------------------------------------------------------
 Squiz.PHP.DisallowMultipleAssignments.Found                      906
 WordPress.PHP.YodaConditions.NotYoda                             692
 WordPress.WP.I18n.MissingTranslatorsComment                      590
 WordPress.NamingConventions.ValidVariableName.NotSnakeCase       423
 WordPress.DB.PreparedSQL.NotPrepared                             334
 Generic.PHP.NoSilencedErrors.Discouraged                         288
 WordPress.NamingConventions.ValidVariableName.NotSnakeCaseMembe  268
 WordPress.WhiteSpace.PrecisionAlignment.Found                    155
 WordPress.NamingConventions.ValidHookName.UseUnderscores         69
 WordPress.Files.FileName.InvalidClassFileName                    52
 WordPress.NamingConventions.ValidFunctionName.MethodNameInvalid  43
 WordPress.NamingConventions.ValidFunctionName.FunctionNameInval  18
 Squiz.ControlStructures.ControlSignature.SpaceAfterCloseBrace    16
 WordPress.NamingConventions.ValidHookName.NotLowercase           14
 WordPress.NamingConventions.ValidVariableName.MemberNotSnakeCas  11
 WordPress.WP.I18n.LowLevelTranslationFunction                    11
 WordPress.WP.I18n.NonSingularStringLiteralText                   11
 WordPress.WP.I18n.NonSingularStringLiteralDomain                 10
 WordPress.NamingConventions.ValidFunctionName.FunctionDoubleUnd  9
 PEAR.NamingConventions.ValidClassName.StartWithCapital           8
 PEAR.NamingConventions.ValidClassName.Invalid                    6
 WordPress.DB.PreparedSQLPlaceholders.UnfinishedPrepare           5
 PSR2.ControlStructures.SwitchDeclaration.TerminatingComment      4
 WordPress.DB.PreparedSQLPlaceholders.UnquotedComplexPlaceholder  4
 WordPress.Files.FileName.NotHyphenatedLowercase                  4
 WordPress.PHP.DontExtract.extract_extract                        4
 WordPress.WP.I18n.MismatchedPlaceholders                         4
 WordPress.WP.I18n.MissingSingularPlaceholder                     4
 WordPress.DB.PreparedSQLPlaceholders.ReplacementsWrongNumber     3
 Generic.NamingConventions.UpperCaseConstantName.ConstantNotUppe  2
 WordPress.WP.I18n.NonSingularStringLiteralPlural                 2
 WordPress.WP.I18n.NonSingularStringLiteralSingle                 2
 WordPress.DB.PreparedSQLPlaceholders.QuotedDynamicPlaceholderGe  1
 WordPress.DB.PreparedSQLPlaceholders.QuotedSimplePlaceholder     1
 WordPress.Files.FileName.InvalidTemplateTagFileName              1
 WordPress.NamingConventions.ValidVariableName.StringNotSnakeCas  1
 WordPress.PHP.RestrictedPHPFunctions.create_function_create_fun  1
 ----------------------------------------------------------------------
 A TOTAL OF 3977 SNIFF VIOLATIONS WERE FOUND IN 37 SOURCES
 ----------------------------------------------------------------------
 }}}

 There's a long tail of sniffs with only a handful of violations, so I'm
 going to go through them. This is a catch-all ticket for them.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/45934>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform