[wp-trac] [WordPress Trac] #44981: Make notice on Privacy Policy page to 'Check out our guide' dismissable
WordPress Trac
noreply at wordpress.org
Thu Jan 10 06:55:58 UTC 2019
#44981: Make notice on Privacy Policy page to 'Check out our guide' dismissable
-------------------------------------------------+-------------------------
Reporter: garrett-eclipse | Owner: garrett-
| eclipse
Type: enhancement | Status: assigned
Priority: normal | Milestone: Future
| Release
Component: Privacy | Version: 4.9.6
Severity: normal | Resolution:
Keywords: has-patch has-screenshots dev- | Focuses:
feedback needs-testing |
-------------------------------------------------+-------------------------
Changes (by garrett-eclipse):
* keywords: has-patch needs-refresh => has-patch has-screenshots dev-
feedback needs-testing
Comment:
Thanks @pento,
Sorry about that, had it working in /build and hadn't applied to /src
before making that original diff.
Latest patch is correct with proper spelling of `is-dismissible` class and
calls `makeNoticesDismissible` on `wp-pp-notice` to invoke the function to
inject the button.
Minor notes;
Upon reload the notice will re-appear which is expected.
As well just this was started pre-5.0 so this notice currently only
displays with Classic Editor enabled.
Please apply the latest and let me know if there's any issues.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/44981#comment:10>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list