[wp-trac] [WordPress Trac] #44839: Privacy-data-requests-tables: Remove inline CSS, move it into a css file instead

WordPress Trac noreply at wordpress.org
Wed Jan 9 05:00:22 UTC 2019


#44839: Privacy-data-requests-tables: Remove inline CSS, move it into a css file
instead
-------------------------------------------------+-------------------------
 Reporter:  birgire                              |       Owner:  desrosj
     Type:  enhancement                          |      Status:  assigned
 Priority:  low                                  |   Milestone:  Future
                                                 |  Release
Component:  Privacy                              |     Version:  4.9.6
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch needs-testing needs-       |     Focuses:
  refresh                                        |
-------------------------------------------------+-------------------------
Changes (by pento):

 * keywords:  has-patch needs-testing => has-patch needs-testing needs-
               refresh
 * milestone:  5.1 => Future Release


Comment:

 I'm inclined to agree that it should use the `.hidden` class.

 This should probably also update `setActionState()` in `xfn.js` to
 add/remove the `hidden` class, instead of using `hide()` and `show()`.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/44839#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list