[wp-trac] [WordPress Trac] #42057: Add ability to pass a label for the <form> element returned by get_search_form()

WordPress Trac noreply at wordpress.org
Wed Jan 9 02:32:58 UTC 2019


#42057: Add ability to pass a label for the <form> element returned by
get_search_form()
---------------------------+----------------------------
 Reporter:  williampatton  |       Owner:  sami.keijonen
     Type:  enhancement    |      Status:  assigned
 Priority:  normal         |   Milestone:  5.1
Component:  General        |     Version:  4.8.2
 Severity:  normal         |  Resolution:
 Keywords:  dev-feedback   |     Focuses:  accessibility
---------------------------+----------------------------

Comment (by pento):

 [attachment:"42057.diff"] needs to be refreshed. Additionally, there are a
 couple of issues I noticed:

 - The function docblock needs an additional `@since` tag, describing the
 parameter change.
 - The 'Back compat' comment block should have `* ` at the start of each
 line.
 - While it's possibly not necessary, we should continue to define `$echo`,
 so that it's available in a custom `searchform.php` file.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/42057#comment:21>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list