[wp-trac] [WordPress Trac] #45859: Not having aria-label tag in the Publish button

WordPress Trac noreply at wordpress.org
Tue Jan 8 16:12:41 UTC 2019


#45859: Not having aria-label tag in the Publish button
-------------------------------+----------------------------
 Reporter:  priyankabehera155  |       Owner:  (none)
     Type:  defect (bug)       |      Status:  closed
 Priority:  normal             |   Milestone:
Component:  General            |     Version:
 Severity:  normal             |  Resolution:  invalid
 Keywords:  has-patch          |     Focuses:  accessibility
-------------------------------+----------------------------
Changes (by afercia):

 * keywords:  has-patch dev-feedback => has-patch
 * status:  new => closed
 * version:  5.0.2 =>
 * resolution:   => invalid
 * milestone:  Awaiting Review =>


Comment:

 @priyankabehera155 thanks and welcome to Trac!

 The [https://www.w3.org/TR/wai-aria-1.1/#aria-label aria-label attribute]
 is meant to give an element a name that can be announced by assistive
 technologies. When an element already has visible text, the name is given
 by its text. The Publish button already has visible text, thus it doesn't
 need an aria-label.

 @mukesh27 thanks for the patch :) However, patches shouldn't be made
 against files in the `dist` directory. Any change to the Block Editor
 should be made on the Gutenberg GitHub repository.

 I'm going to close this ticket, please do feel free to reopen if I'm
 missing something.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/45859#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list