[wp-trac] [WordPress Trac] #45615: CSV Mime Type fails upload
WordPress Trac
noreply at wordpress.org
Mon Jan 7 17:34:30 UTC 2019
#45615: CSV Mime Type fails upload
--------------------------------------+------------------------
Reporter: Kloon | Owner: joemcgill
Type: defect (bug) | Status: assigned
Priority: normal | Milestone: 5.0.3
Component: Upload | Version: 5.0.1
Severity: normal | Resolution:
Keywords: has-patch has-unit-tests | Focuses:
--------------------------------------+------------------------
Comment (by joemcgill):
For 5.0.3, I don't think we should remove vtt and dfxp files from the list
of supported mime types. [attachment:"45615.6.diff"] leaves those file
types in the array of supported mime types, removes the tests requiring a
filter for these types. I've also adjusted the json test to expect a
`text/plain` file type because that test was failing for me. I don't think
we even really need that test for 5.0.3, though I agree with the idea to
include tests for a suggested filter overrides for this functionality,
generally.
[attachment:"45615.7.diff"] is the same as [attachment:"45615.6.diff"] but
removes the unsupported file type unit tests for now. I think this is a
good iterative approach for 5.0.3 that fixes a few of the common errors
for files being misidentified as `text/plain`.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/45615#comment:42>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list