[wp-trac] [WordPress Trac] #42334: Enter/Escape keys don't have an affect in the locked content modal
WordPress Trac
noreply at wordpress.org
Sun Jan 6 23:31:07 UTC 2019
#42334: Enter/Escape keys don't have an affect in the locked content modal
-------------------------------------+-------------------------------------
Reporter: johnbillion | Owner: (none)
Type: enhancement | Status: new
Priority: normal | Milestone: 5.1
Component: Editor | Version:
Severity: normal | Resolution:
Keywords: needs-patch has-ux- | Focuses: accessibility,
feedback | javascript, administration
-------------------------------------+-------------------------------------
Comment (by afercia):
This modal is a bit different from all the other modal dialogs, as it
can't be dismissed and instead requires to choose an action. In all the
other modals, Escape dismiss the modal. I'm not sure making Escape trigger
navigation back to All Post would be the expected interaction.
I'm not sure why users at this point would want to preview the post, so
I'd just remove the "Preview" button.
So if the available actions are only two, I'd tend to think Enter should
not trigger the `Take over` button: that would be unexpected, I can't
think of a place in WordPress where Enter triggers the primary button.
Also, I'm not sure "All Posts" is appropriate, as it's not so clear it
will navigate back to the Posts overview. I'd rather simplify the logic
and always use the text `Go back`.
From an accessibility perspective, the lack of an ARIA `role="dialog"` and
a visible title are way more important issues.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/42334#comment:9>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list