[wp-trac] [WordPress Trac] #38034: post__in orderby not working when passed in an array to orderby

WordPress Trac noreply at wordpress.org
Fri Jan 4 21:48:51 UTC 2019


#38034: post__in orderby not working when passed in an array to orderby
--------------------------+-----------------------------
 Reporter:  kelvink       |       Owner:  (none)
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  Future Release
Component:  Query         |     Version:  4.6
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |     Focuses:
--------------------------+-----------------------------

Comment (by boonebgorges):

 Thanks, @mgibbs189. Am I correct that lines 1644-1647 (right side) of
 [attachment:"38034.3.diff"] are the key changes from
 [attachment:"38034.2.diff"] ? I ask because we generally don't mix general
 code factoring with bug fixes, so they'll have to go in separately. (and
 in fact, we shy away from doing general code refactoring without cause, as
 it risks introducing bugs. That said, your changes certainly look ok at a
 glance :) )

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/38034#comment:17>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list