[wp-trac] [WordPress Trac] #43170: Replace all usages of basename() with wp_basename() in order to support multibyte filenames

[WordPress Trac]

#43170: Replace all usages of basename() with wp_basename() in order to support
multibyte filenames
--------------------------+---------------------
 Reporter:  Viper007Bond  |       Owner:  (none)
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  5.2
Component:  Media         |     Version:  4.9.2
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |     Focuses:
--------------------------+---------------------
Changes (by jorbin):

 * keywords:  needs-patch => has-patch
 * milestone:  Awaiting Review => 5.2


Comment:

 I might be feeling a bit YOLO, or having a little too much faith in your
 unit tests, but I think this is actually something we can fix in one go.
 The above patch changes every reference to basename to wp_basename except
 for 2:

 1) inside the wp_basename function, we still use basename.
 2) inside the unit test bootstrap, we still use basename for the config
 file.

 Unless I hear some objections, I'm going to land this early in the 5.2
 cycle (i.e. this week). It can always be reverted if it does break things.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/43170#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform