[wp-trac] [WordPress Trac] #46167: Network update does not create wp_blogmeta table

[WordPress Trac]

#46167: Network update does not create wp_blogmeta table
-----------------------------+------------------------
 Reporter:  waryn            |       Owner:  (none)
     Type:  defect (bug)     |      Status:  reopened
 Priority:  normal           |   Milestone:  5.1.1
Component:  Upgrade/Install  |     Version:  5.1
 Severity:  major            |  Resolution:
 Keywords:                   |     Focuses:  multisite
-----------------------------+------------------------

Comment (by pbiron):

 It has now happened to me, when updating from 5.0.3 to 5.1 from `wp-
 admin/network/upgrade-core.php` (i.e., **not** via `wp-cli`, the `wp-beta-
 tester` plugin, etc).

 I've tried several more times but haven't been able to get it to happen
 **again** after that one time.

 Luckily, the one time it did happen I was actually stepping through the
 upgrade process in a debugger (not an easy task, since the line numbers
 where you have breakpoints set change when the new files get copied over
 :-).

 As this was the first time I really followed what happens during a core
 update, I think I stepped over the part that actually caused the
 `blogmeta` table to not be created.  But, as far as I could tell,
 somewhere before L2593 in
 [[https://core.trac.wordpress.org/browser/tags/5.1/src/wp-
 admin/includes/upgrade.php#L2593|dbDelta()]] `$cqueries` ended up as an
 empty array...rather than containing the `CREATE TABLE` statement that is
 supposed to create the `blogmeta` table.

 As far as I can tell, I did not have any plugins active that hook into
 [[https://developer.wordpress.org/reference/hooks/dbdelta_queries/|dbdelta_queries]]
 or
 [[https://developer.wordpress.org/reference/hooks/dbdelta_create_queries/|dbdelta_create_queries]],
 which is the only way I can see for `$cqueries` to be empty.

 Hopefully, this will help someone else find the problem.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/46167#comment:14>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform