[wp-trac] [WordPress Trac] #46304: On the privacy request table buttons switch to break-word for legibility
WordPress Trac
noreply at wordpress.org
Fri Feb 22 17:53:30 UTC 2019
#46304: On the privacy request table buttons switch to break-word for legibility
-----------------------------------------------+---------------------------
Reporter: garrett-eclipse | Owner: garrett-
| eclipse
Type: defect (bug) | Status: assigned
Priority: normal | Milestone: Awaiting
| Review
Component: Privacy | Version: 4.9.6
Severity: normal | Resolution:
Keywords: has-patch 2nd-opinion ui-feedback | Focuses: ui
-----------------------------------------------+---------------------------
Changes (by garrett-eclipse):
* keywords: => has-patch 2nd-opinion ui-feedback
* owner: (none) => garrett-eclipse
* status: new => assigned
Comment:
Replying to [comment:1 afercia]:
> Seems this was intentional, see [43282]. Worth investigating on the
reasons for that change, see the related ticket.
Thanks @afercia I see what you mean with the second commit switching to
break-all. I went through Slack and Trac surrounding the ticket and
couldn't find any explanation provided. Maybe @azzozz has information as
he made both commits. Only thought I had was the original CSS was `word-
break: break-word;` which isn't an official value and is only supported on
Webkit browsers.
Reference - https://caniuse.com/#search=word-break
*Also it seems to indicate `break-all` is only partially supported.
From my investigation on Trac and Google is that the norm for this sort of
thing appears to be going with `word-wrap: break-word;` as it's most
widely supported.
Reference - https://caniuse.com/#search=overflow-wrap
Other Trac tickets/changes that went with `word-wrap: break-word;`:
https://meta.trac.wordpress.org/ticket/1157
https://core.trac.wordpress.org/ticket/36207
https://core.trac.wordpress.org/ticket/22554
https://core.trac.wordpress.org/ticket/22359
Replying to [comment:1 afercia]:
> I'd also note the CSS value `unset` used for `white-space` is not
supported by IE11 and shouldn't be used.
Thanks for pointing that out, I supplied a patch where I switched it to
'normal'. Is that a fairly safe approach or do you recommend a different
setting?
--
Ticket URL: <https://core.trac.wordpress.org/ticket/46304#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list