[wp-trac] [WordPress Trac] #46320: Replace http with https in the link placeholder widget image

WordPress Trac noreply at wordpress.org
Fri Feb 22 17:17:42 UTC 2019


#46320: Replace http with https in the link placeholder widget image
---------------------------------------------+-----------------------------
 Reporter:  Chaton666                        |       Owner:  audrasjb
     Type:  enhancement                      |      Status:  reviewing
 Priority:  normal                           |   Milestone:  Awaiting
                                             |  Review
Component:  Widgets                          |     Version:
 Severity:  normal                           |  Resolution:
 Keywords:  has-patch has-screenshots close  |     Focuses:  administration
---------------------------------------------+-----------------------------

Comment (by audrasjb):

 Hi @johnbillion

 In `46320.diff` there is two changes:
 - the change on `src/js/media/views/settings/attachment-display.js` is not
 a good idea. But it's not a good idea to use the `value` attribute too. We
 should only use the `placeholder` attribute. Also, this change is not
 strictly related to the ticket. It should be a specific ticket assigned to
 #core-media team. I think we need a new patch without this change.
 - the change on `src/wp-includes/widgets/class-wp-widget-media-image.php`
 looks nice on my side. This is only a placeholder. We should encourage the
 use of https instead of http.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/46320#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list