[wp-trac] [WordPress Trac] #46312: Replace http with https in custom links menu item
WordPress Trac
noreply at wordpress.org
Fri Feb 22 12:47:04 UTC 2019
#46312: Replace http with https in custom links menu item
-------------------------------------------------+-------------------------
Reporter: aksl95 | Owner: audrasjb
Type: enhancement | Status: accepted
Priority: normal | Milestone: 5.2
Component: Menus | Version:
Severity: normal | Resolution:
Keywords: has-patch has-screenshots needs- | Focuses:
refresh |
-------------------------------------------------+-------------------------
Changes (by audrasjb):
* keywords: has-patch has-screenshots => has-patch has-screenshots needs-
refresh
Comment:
Hi @mukesh27 thanks for the update :)
Changing `value` to `placeholder` attribute is nice, but I don't think we
should check `is_ssl()` since Custom links can handle external links as
well. We should let https by default in my opinion (as a placeholder) ;-)
--
Ticket URL: <https://core.trac.wordpress.org/ticket/46312#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list