[wp-trac] [WordPress Trac] #46300: Return type/value of get_site is not being checked in wp_insert_site
WordPress Trac
noreply at wordpress.org
Thu Feb 21 21:18:08 UTC 2019
#46300: Return type/value of get_site is not being checked in wp_insert_site
--------------------------------+------------------------
Reporter: david.binda | Owner: (none)
Type: enhancement | Status: new
Priority: normal | Milestone: 5.1.1
Component: Networks and Sites | Version: trunk
Severity: normal | Resolution:
Keywords: | Focuses: multisite
--------------------------------+------------------------
Changes (by pento):
* milestone: Awaiting Review => 5.1.1
Comment:
Good find, thanks @davidbinda! Putting this in 5.1.1, as it's mostly about
better error case handling. If `get_site()` has failed immediately after
the `$wpdb->insert()` succeeds, there are probably bigger problems. 🙂
--
Ticket URL: <https://core.trac.wordpress.org/ticket/46300#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list