[wp-trac] [WordPress Trac] #41373: WordPress 4.8 and WPML returns NULL on retrieve of translated slugname. Only ID works

WordPress Trac noreply at wordpress.org
Thu Feb 21 02:44:23 UTC 2019


#41373: WordPress 4.8 and WPML returns NULL on retrieve of translated slugname.
Only ID works
-------------------------------------------------+-------------------------
 Reporter:  BackuPs                              |       Owner:  (none)
     Type:  defect (bug)                         |      Status:  closed
 Priority:  normal                               |   Milestone:
Component:  Taxonomy                             |     Version:  4.8
 Severity:  normal                               |  Resolution:  wontfix
 Keywords:  needs-testing needs-unit-tests       |     Focuses:
  reporter-feedback                              |
-------------------------------------------------+-------------------------
Changes (by boonebgorges):

 * status:  new => closed
 * resolution:   => wontfix
 * milestone:  Awaiting Review =>


Comment:

 It's unfortunate that [38677] caused this unexpected change in behavior,
 and especially unfortunate that it wasn't caught before the 4.8 release.
 This points to two things:
 - the need for the core team to be more thorough about canvassing possible
 regressions of this sort when making this kind of internal change - I
 personally hadn't thought about the sort of case described here when
 working on #21760 - and then communicating them clearly to plugin devs
 well in advance.
 - Developers of major plugins should be testing beta, and ideally alpha,
 versions of major WordPress releases for regressions of this sort.

 All this being said: While the changes to `get_term_by()` were implemented
 in a way that caused some unintended fallout, the changes themselves were
 good ones. WPML, and presumably other plugins, have since updated their
 uses of `get_term_by()` to mitigate any problems. As such, I think that no
 further action is appropriate on this ticket. Apologies to those affected,
 especially for the lapses in communication.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/41373#comment:16>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list