[wp-trac] [WordPress Trac] #45817: Twenty Nineteen: h4 and links styling in editor does not match actual

WordPress Trac noreply at wordpress.org
Wed Feb 20 21:12:59 UTC 2019


#45817: Twenty Nineteen: h4 and links styling in editor does not match actual
---------------------------+------------------------------
 Reporter:  brianhogg      |       Owner:  (none)
     Type:  defect (bug)   |      Status:  new
 Priority:  normal         |   Milestone:  Awaiting Review
Component:  Bundled Theme  |     Version:  5.0.2
 Severity:  normal         |  Resolution:
 Keywords:                 |     Focuses:
---------------------------+------------------------------

Comment (by laurelfulford):

 Thanks for this report, @brianhogg!

 It looks like the plugin adds the `.entry-title` class -- the same class
 used on post titles in many themes -- to each `h4` it outputs.

 It does the same in the editor, but because the `.entry-title` styles
 wouldn't be included on that selector in a theme's editor styles (since
 the title is a text input in the editor, with different classes), the
 styles don't line up.

 I was able to recreate similar issues in Twenty Seventeen and Twenty
 Sixteen, where the `h4` with the `.entry-title` class inherited the font
 size, weight and/or family from the `.entry-title` class, causing it to
 display differently on the front-end.

 I see that The Events Calendar Block is your plugin. I'm not sure which is
 the intended header size -- either in the editor, with the smaller `h4`,
 or the larger version on the front-end. If it's the former, removing the
 `.entry-title` class should get the title inheriting individual theme's
 `h4` styles.

 If it's the latter, that's a bit trickier -- as mentioned, the `.entry-
 title` class doesn't exist in the editor, so the plugin might have to rely
 on using a different heading tag to get larger headers that display
 consistently across Gutenberg-supporting themes, rather than a class.

 The theme itself seems to functioning as expected, so I'm going to close
 this issue. But please let me know if you have any questions at all about
 the above!

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/45817#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list