[wp-trac] [WordPress Trac] #46280: Uncaught javascript error on comment-reply.js

[WordPress Trac]

#46280: Uncaught javascript error on comment-reply.js
---------------------------------------------------+---------------------
 Reporter:  xknown                                 |       Owner:  (none)
     Type:  defect (bug)                           |      Status:  new
 Priority:  normal                                 |   Milestone:  5.1
Component:  Comments                               |     Version:  trunk
 Severity:  normal                                 |  Resolution:
 Keywords:  has-patch needs-refresh needs-testing  |     Focuses:
---------------------------------------------------+---------------------
Changes (by pento):

 * keywords:  needs-patch => has-patch needs-refresh needs-testing


Comment:

 [attachment:"46280.diff"] fixes this particular error.

 While testing, I noticed that `moveForm()` is called twice, because P2
 adds its own `onclick` attribute to the Reply button. I'm thinking the
 `clickEvent()` should only be attached to the Reply button if that element
 has all of the necessary data attributes. Otherwise, assume that the
 comment was generated by a custom callback sent to `wp_list_comments()`,
 as P2 does.

 I'm leaning towards targeting this fix for WordPress 5.1.1, as we're only
 a day out from WordPress 5.1 being released.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/46280#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform