[wp-trac] [WordPress Trac] #46260: 5.1 Backwards Compatibility Issue: comment-reply.js
WordPress Trac
noreply at wordpress.org
Mon Feb 18 04:03:18 UTC 2019
#46260: 5.1 Backwards Compatibility Issue: comment-reply.js
-----------------------------------+----------------------------
Reporter: iCaleb | Owner: peterwilsoncc
Type: defect (bug) | Status: accepted
Priority: normal | Milestone: 5.1
Component: Comments | Version: trunk
Severity: normal | Resolution:
Keywords: has-patch 2nd-opinion | Focuses:
-----------------------------------+----------------------------
Comment (by peterwilsoncc):
[attachment:"46260.4.diff"] is almost identical to
[attachment:"46260.3.diff"]:
* Since tag on `observeChanges()`
* Moved `MutationObserver` declaration to avoid re-defintion
* Trailing comma removed on `observerOptions`
* Minor golfing change to `init()`.
I've tested it with the plugin highlighted but needed to debug the plugin
first as it uses some long-lost jQuery attribute selectors.
I considered including `MutationObserver` in the ''cuts the mustard''
check but ultimately left it out for a little wider browser support for
sites loading comments in the traditional WordPress fashion.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/46260#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list