[wp-trac] [WordPress Trac] #46260: 5.1 Backwards Compatibility Issue: comment-reply.js

[WordPress Trac]

#46260: 5.1 Backwards Compatibility Issue: comment-reply.js
-----------------------------------+---------------------
 Reporter:  iCaleb                 |       Owner:  (none)
     Type:  defect (bug)           |      Status:  new
 Priority:  normal                 |   Milestone:  5.1
Component:  Comments               |     Version:  trunk
 Severity:  normal                 |  Resolution:
 Keywords:  has-patch 2nd-opinion  |     Focuses:
-----------------------------------+---------------------
Changes (by pento):

 * keywords:   => has-patch 2nd-opinion


Comment:

 [attachment:"46260.diff"] fixes this by event bubbling, rather than
 `MutationObserver`.

 I have no strong preference either way, this is just the approach I took
 first.

 Looking at the code and discussion on #31590, it appears intentional that
 Ajax comment loaders will need to call `window.addComment.init()`, but I
 couldn't find a devnote to match. @peterwilsoncc, I don't suppose you
 recall any additional context on this decision?

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/46260#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform