[wp-trac] [WordPress Trac] #46239: Twenty Nineteen: Remove forced left border from pullquote block.
WordPress Trac
noreply at wordpress.org
Tue Feb 12 14:41:12 UTC 2019
#46239: Twenty Nineteen: Remove forced left border from pullquote block.
---------------------------+-----------------------------
Reporter: kjellr | Owner: (none)
Type: defect (bug) | Status: new
Priority: normal | Milestone: Awaiting Review
Component: Bundled Theme | Version:
Severity: normal | Keywords: has-patch
Focuses: |
---------------------------+-----------------------------
An upcoming Gutenberg change will effect behavior of the border on pull
quote blocks:
https://github.com/WordPress/gutenberg/pull/13248
This change will mean:
- Pullquote blocks that are left-aligned will have a left border (like
they do today).
- Pullquote blocks that are centered will have no border.
- Pullquote blocks that are right-aligned will have a right border.
Twenty Nineteen's custom styles currently force a left border on pullquote
blocks, regardless of their alignment. This leads to double borders on
right-aligned elements when testing that PR:
[[Image(https://cldup.com/BgZMzFsMzd-2000x2000.png)]]
This PR adjusts Twenty Nineteen's styles to be a little less specific.
Instead of supplying the `border-style`, `border-width`, and `border-
color` in shorthand, this patch specifies only the `border-width`, and
`border-color`. This lets pullquote blocks inherit the `border-style` (and
location) from Gutenberg.
It should have no effect on pullquotes or plain blockquotes as they are
today, but will prevent a double border when the aforementioned Gutenberg
PR is merged in.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/46239>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list