[wp-trac] [WordPress Trac] #44643: CSS line-height values should be unitless unless necessary to be defined as a specific pixel value

WordPress Trac noreply at wordpress.org
Wed Feb 6 19:39:19 UTC 2019


#44643: CSS line-height values should be unitless unless necessary to be defined as
a specific pixel value
-------------------------------------+-------------------------------------
 Reporter:  pbiron                   |       Owner:  ianbelanger
     Type:  defect (bug)             |      Status:  assigned
 Priority:  normal                   |   Milestone:  Future Release
Component:  General                  |     Version:
 Severity:  normal                   |  Resolution:
 Keywords:  needs-patch needs-dev-   |     Focuses:  ui, administration,
  note                               |  coding-standards
-------------------------------------+-------------------------------------

Comment (by ianbelanger):

 Notes for 44643.customize-controls.css.diff

 In `wp-admin/css/customize-controls.css`

 Unchanged line-height values that use units (I could not find a good
 unitless solution that would work across all browsers and admin pages)
 {{{
 line 443 - #customize-controls .customize-pane-child .customize-section-
 title h3, #customize-controls .customize-pane-child h3.customize-section-
 title, #customize-outer-theme-controls .customize-pane-child .customize-
 section-title h3, #customize-outer-theme-controls .customize-pane-child h3
 .customize-section-title, #customize-controls .customize-info .panel-title
 line 755 - .customize-section-title h3, h3.customize-section-title (This
 style is overidden by the above rule anyway and could probably be removed)
 line 983 - .customize-control-color .color-picker, .customize-control-
 upload div
 line 2900 - #available-widgets .customize-section-title h3, #available-
 menu-items .customize-section-title h3
 }}}

 Unable to find selectors in the DOM
 {{{
 line 987 - .customize-control .customize-inside-control-row
 line 1271 - .accordion-section .dropdown-content
 line 1405 - .customize-control-header .inner, .customize-control-header
 .inner .dashicons
 line 1869 - .control-section .customize-section-text-before
 line 2198 - .wp-customizer .showing-themes .control-panel-themes
 .customize-themes-mobile-back:before
 line 2745 - .customize-control input[type="radio"] + label + br,
 .customize-control input[type="checkbox"] + label + br
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/44643#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list