[wp-trac] [WordPress Trac] #47398: Remove wp_favicon_request

[WordPress Trac]

#47398: Remove wp_favicon_request
----------------------------------+-----------------------------
 Reporter:  jonoaldersonwp        |       Owner:  SergeyBiryukov
     Type:  enhancement           |      Status:  reviewing
 Priority:  normal                |   Milestone:  5.4
Component:  Bootstrap/Load        |     Version:
 Severity:  normal                |  Resolution:
 Keywords:  has-patch seo commit  |     Focuses:
----------------------------------+-----------------------------
Changes (by SergeyBiryukov):

 * keywords:  has-patch seo => has-patch seo commit


Comment:

 [attachment:"47398.5.diff"] simplifies things a bit to address the
 concerns raised in comment:17:

 * Use `get_site_icon_url()` with a fallback icon, same as in
 [source:tags/5.3.2/src/wp-includes/embed.php?marks=1175,1176#L1162
 the_embed_site_title()].
 * Perform a 302 redirect to the icon URL, instead of trying to serve it in
 PHP. That way we don't have to deal with `allow_url_fopen` limitations,
 differentiating between local vs. external icons, etc.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/47398#comment:20>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform