[wp-trac] [WordPress Trac] #49059: Whitespace inside p element in wp-signup.php should be removed

[WordPress Trac]

#49059: Whitespace inside p element in wp-signup.php should be removed
--------------------------------+------------------------------------------
 Reporter:  henry.wright        |       Owner:  johnjamesjacoby
     Type:  enhancement         |      Status:  assigned
 Priority:  normal              |   Milestone:  5.4
Component:  Networks and Sites  |     Version:  3.0
 Severity:  normal              |  Resolution:
 Keywords:  close               |     Focuses:  multisite, coding-standards
--------------------------------+------------------------------------------

Comment (by azaozz):

 Replying to [comment:20 johnjamesjacoby]:
 > > just makes this part of the code a bit more inconsistent, and a bit
 harder to read
 >
 > Statements like this are not helpful.

 I'm sorry but I don't see what's "not helpful" here? :)

 As posted abode, IDEs can highlight HTML tags nicely but not when they are
 outputted as static/hard-coded PHP strings.

 > "Better" and "worse" are opinions. "Inconsistent" is relative, because
 this patch is literally only about providing consistency to this file.
 > ...
 > can you please patch this file yourself here so others can better
 understand what you mean?

 Yep, I understand. My opinion is that "white space" changes like this one
 should not be done one-file-at-a-time and should be considered as part of
 the coding standards. Otherwise this results in adding more and more
 "cases" to the 8,000 `?>` and about 700 `echo 'string';` which doesn't
 "fix" anything. That's why I added the `close` keyword.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/49059#comment:22>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform