[wp-trac] [WordPress Trac] #49059: Whitespace inside p element in wp-signup.php should be removed

WordPress Trac noreply at wordpress.org
Mon Dec 23 19:25:07 UTC 2019


#49059: Whitespace inside p element in wp-signup.php should be removed
--------------------------------+------------------------------------------
 Reporter:  henry.wright        |       Owner:  johnjamesjacoby
     Type:  enhancement         |      Status:  assigned
 Priority:  normal              |   Milestone:  5.4
Component:  Networks and Sites  |     Version:  3.0
 Severity:  normal              |  Resolution:
 Keywords:  close               |     Focuses:  multisite, coding-standards
--------------------------------+------------------------------------------

Comment (by azaozz):

 Replying to [comment:15 henry.wright]:
 > I think the approach used in the patch is a nice improvement.

 Sorry but I don't think so. This is (mostly) a "coding standards"
 question, and I agree with @johnjamesjacoby that this ticket is not the
 place to propose or discuss changes there :)

 Switching from stopping and starting the interpreter to `echo` just makes
 this part of the code a bit more inconsistent, and a bit harder to read
 (IDEs can highlight HTML tags nicely but not when they are outputted as
 static/hard-coded PHP strings).

 The general idea in the WP coding standards is that source code
 readability is more important than controlling white space in the
 outputted HTML. This includes formatting the source code in a way that is
 easy to highlight by various IDEs and "source code editors", and keeping
 HTML and PHP easily distinguishable when reading the code.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/49059#comment:18>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list