[wp-trac] [WordPress Trac] #49056: Can we stop bundling default themes?

[WordPress Trac]

#49056: Can we stop bundling default themes?
-----------------------------+------------------------------
 Reporter:  crdunst          |       Owner:  (none)
     Type:  defect (bug)     |      Status:  new
 Priority:  normal           |   Milestone:  Awaiting Review
Component:  Upgrade/Install  |     Version:
 Severity:  minor            |  Resolution:
 Keywords:  close            |     Focuses:
-----------------------------+------------------------------

Comment (by SergeyBiryukov):

 Replying to [comment:2 crdunst]:
 > 2) If WP doesn't handle 'no themes' gracefully, shouldn't we change that
 behaviour? A simple message on the front-end, and a notice on the back-
 end: "you have no theme installed, please install one" or similar?

 I think that was addressed in [25666] / #21670 and [36335] / #21931.

 Replying to [comment:6 tomgreer]:
 > I disagree with the argument about the need for fallback in case the
 active theme can't be loaded.

 Another argument is that not bundling new default themes provides a bad
 user experience for users seeking to experiment with them, see [39064] /
 #38551.

 Replying to [comment:7 tomgreer]:
 > Please clarify, what value should be assigned to
 CORE_UPGRADE_SKIP_NEW_BUNDLED to tell WordPress not to installs themes
 when the core is updated?

 Thanks for point that out, it does look confusing.

 Reading through the related commits and tickets:

 * [17576] / #14484
 * [18225] / #10611
 * [22226] / #21789
 * [35738] / #34306
 * [39064] / #38551

 The comment [comment:8:ticket:34306] clarifies the intention behind
 explicitly setting the constant to `false`, but that still seems counter-
 intuitive. Some implementation details have changed between
 [attachment:34306.2.diff:ticket:34306] and
 [attachment:34306.3.diff:ticket:34306].

 It looks like current comment refers to a part of [35738] that was later
 reverted in [39064]. The comment should be updated to reflect the initial
 intention of the constant as introduced in [17576] /
 [comment:23:ticket:14484].

 To summarize, in order to tell WordPress not to install new themes on
 update, `CORE_UPGRADE_SKIP_NEW_BUNDLED` should be set to `true`, as the
 name suggests.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/49056#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform