[wp-trac] [WordPress Trac] #49059: Whitespace inside p element in wp-signup.php should be removed

WordPress Trac noreply at wordpress.org
Sat Dec 21 18:39:36 UTC 2019


#49059: Whitespace inside p element in wp-signup.php should be removed
--------------------------------+------------------------------------------
 Reporter:  henry.wright        |       Owner:  johnjamesjacoby
     Type:  enhancement         |      Status:  assigned
 Priority:  normal              |   Milestone:  5.4
Component:  Networks and Sites  |     Version:  3.0
 Severity:  normal              |  Resolution:
 Keywords:  close               |     Focuses:  multisite, coding-standards
--------------------------------+------------------------------------------

Comment (by johnjamesjacoby):

 > Looking at the patches here, it seems they are not 100% compatible with
 the coding standards

 Which standard? šŸ˜

 > Better readability in PHP is preferable to some white space in HTML as
 the latter is reformatted by the browser tools when viewed.

 Define ā€œbetter readability.ā€ The patches attached to this ticket look
 better to me, which is why Iā€™m suggesting them. They are more uniform.
 They match the surrounding code. They are less syntactically complicated.
 They are more obvious than breaking in and out of PHP a dozen times if the
 opposite approach were suggested instead.

 Your better is worse for me.

 Iā€™m recommending we make these changes here without the need to call a
 formal Slack meeting to re-discuss what a committee-of-everyone else
 thinks is best everywhere else, because this shouldnā€™t be a design-by-
 committee decision; itā€™s a tiny quality-of-life improvement in a multisite
 file.

 Case in point are the number of times tickets like this get opened through
 the years. There is clearly an audience of contributors that does not find
 the current approach to be ā€œbetterā€ nor even correct. It is easily
 corrected with zero fear of breakage or regression.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/49059#comment:10>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list