[wp-trac] [WordPress Trac] #49059: Whitespace inside p element in wp-signup.php should be removed

WordPress Trac noreply at wordpress.org
Sat Dec 21 16:12:38 UTC 2019


#49059: Whitespace inside p element in wp-signup.php should be removed
--------------------------------+------------------------------
 Reporter:  henry.wright        |       Owner:  johnjamesjacoby
     Type:  enhancement         |      Status:  assigned
 Priority:  normal              |   Milestone:  5.4
Component:  Networks and Sites  |     Version:  3.0
 Severity:  normal              |  Resolution:
 Keywords:  commit              |     Focuses:  multisite
--------------------------------+------------------------------

Comment (by johnjamesjacoby):

 @SergeyBiryukov you are correct there are other instances in core where
 this happens. Although minor, I have for years always thought them to be
 worth correcting.

 The problem I have always seen with them is the markup they produce is
 oddly difficult to follow when viewing source.

 While modern tooling and browser inspectors have helped improve that
 experience, I see no harm in removing some instances of jumping in and out
 of `<?php` simply to output a wrapping HTML Tag when so many other places
 in the same file are already concatenating them.

 I'd prefer to clean this part of the house up, rather than sweep it under
 the rug.

 I don't think every instance you've brought up needs a separate ticket.
 I/we could normalize all of them here.

 The hidden added benefit that I have not tested, is simpler code sniffing
 of this file simply from having less complicated PHP & HTML intermingled.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/49059#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list