[wp-trac] [WordPress Trac] #44264: Give progress indication for export and erasure
WordPress Trac
noreply at wordpress.org
Fri Dec 20 18:45:38 UTC 2019
#44264: Give progress indication for export and erasure
-------------------------------------------------+-------------------------
Reporter: allendav | Owner: garrett-
| eclipse
Type: enhancement | Status: accepted
Priority: normal | Milestone: 5.4
Component: Privacy | Version: 4.9.6
Severity: normal | Resolution:
Keywords: has-patch has-screenshots needs- | Focuses: ui,
testing needs-design-feedback | javascript
-------------------------------------------------+-------------------------
Changes (by garrett-eclipse):
* keywords: needs-design has-patch needs-refresh => has-patch has-
screenshots needs-testing needs-design-feedback
* owner: (none) => garrett-eclipse
* status: new => accepted
* milestone: Future Release => 5.4
Comment:
Thanks for the patch refresh there @dominic_ks it worked really nicely.
In [https://core.trac.wordpress.org/attachment/ticket/44264/44264.2.diff
44264.2.diff] I made the following minor changes;
- Fixed PHPCS issues for spacing
- Changed 'delete-progress' to 'erasure-progress' as the tool is for
Erasures which don't always involve deletions.
- Changed '$progresCont' to just '$progress' as we want full words for
variable naming and I wasn't sure what the 'Cont' meant.
Uploaded some gifs to illustrate the Progress indicators for both the
Export and Erasure tools.
This looks great so let's get it in for 5.4 after some more testing. Also
just adding `needs-design-feedback` to ensure the design team like this
direction.
Note: For testing unless you expand upon the number of exporters/erasures
in your test install it'll always be a quick progress as by default
there's not many.
And last question, not sure if it's worth it but am wondering if we should
add progress indicators for the admins in the cases they use the admin
links for 'Download Personal Data' [Export] and 'Force Erase Personal
Data' [Erasure]. These are found by the admin when they hover over the row
as row-actions. *I'll post some screens to illustrate.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/44264#comment:9>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list