[wp-trac] [WordPress Trac] #43805: Add "in reply to" in comment moderation email notification
WordPress Trac
noreply at wordpress.org
Fri Dec 20 12:38:27 UTC 2019
#43805: Add "in reply to" in comment moderation email notification
--------------------------------------+-----------------------------
Reporter: galbaras | Owner: SergeyBiryukov
Type: enhancement | Status: reviewing
Priority: normal | Milestone: 5.4
Component: Comments | Version:
Severity: normal | Resolution:
Keywords: has-patch has-unit-tests | Focuses: administration
--------------------------------------+-----------------------------
Changes (by imath):
* keywords: has-patch needs-testing => has-patch has-unit-tests
Comment:
Hi @andraganescu
Thanks a lot for the patch and for refreshing it.
1. I advise you to use the `--no-prefix` option when building your patch
so that people using SVN can apply it.
2. I believe it's best to cast the `comment_parent` as an integer for the
strict comparison as `get_comment()` is returning a string for the
`comment_parent` property.
3. I guess if we include the "in reply to" information for post authors,
we should probably also include this information for moderators.
[https://core.trac.wordpress.org/attachment/ticket/43805/43805.3.diff
43805.3.diff] is adding these 3 points and 4 unit tests. I've also tested
the patch regularly with success.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/43805#comment:9>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list