[wp-trac] [WordPress Trac] #48401: Saving a Post Breaks in Gutenberg if you have a custom taxonomy named Status

WordPress Trac noreply at wordpress.org
Thu Dec 19 14:54:48 UTC 2019


#48401: Saving a Post Breaks in Gutenberg if you have a custom taxonomy named
Status
-------------------------------------------------+-------------------------
 Reporter:  kingkool68                           |       Owner:  fgiannar
     Type:  defect (bug)                         |      Status:  assigned
 Priority:  normal                               |   Milestone:  5.4
Component:  REST API                             |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  good-first-bug needs-refresh has-    |     Focuses:
  unit-tests                                     |
-------------------------------------------------+-------------------------

Comment (by fgiannar):

 Thanks a lot for your feedback @TimothyBlynJacobs !

 Just a question please on your suggested message:
 I think that the `_doing_it_wrong` warning could be issued not only if the
 taxonomy name conflicts with an existing property, but also the rest_base,
 as the code to decide on the base is:
 `$base                          = ! empty( $taxonomy->rest_base ) ?
 $taxonomy->rest_base : $taxonomy->name;`

 So, if for example, one had set 'status' as the rest_base the same warning
 would be produced.
 Maybe if we only mention the name on the warning it could be misleading.

 What do you think?

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/48401#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list