[wp-trac] [WordPress Trac] #48957: Call to a member function format() on boolean in wp-includes/feed.php

[WordPress Trac]

#48957: Call to a member function format() on boolean in wp-includes/feed.php
--------------------------------------+-----------------------
 Reporter:  dd32                      |       Owner:  Rarst
     Type:  defect (bug)              |      Status:  assigned
 Priority:  high                      |   Milestone:  5.3.2
Component:  Date/Time                 |     Version:  5.3.1
 Severity:  normal                    |  Resolution:
 Keywords:  has-patch has-unit-tests  |     Focuses:
--------------------------------------+-----------------------

Comment (by Rarst):

 I am not 100% confident on passing `false` case through the filter though.
 I hate it when return filter randomly doesn't apply to some of the
 branches, but in modern PHP I would not add a different type to something
 established. Previously fallback case could return `false` but w/o passing
 through the filter.

 Intuitively I think passing everything and updating documentation is the
 way this time, but open to feedback.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/48957#comment:11>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform