[wp-trac] [WordPress Trac] #48145: Random PHP test failures

[WordPress Trac]

#48145: Random PHP test failures
------------------------------+-----------------------------
 Reporter:  SergeyBiryukov    |       Owner:  SergeyBiryukov
     Type:  defect (bug)      |      Status:  closed
 Priority:  low               |   Milestone:  5.4
Component:  Build/Test Tools  |     Version:
 Severity:  normal            |  Resolution:  fixed
 Keywords:  needs-patch       |     Focuses:
------------------------------+-----------------------------
Changes (by SergeyBiryukov):

 * owner:  (none) => SergeyBiryukov
 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"46968" 46968]:
 {{{
 #!CommitTicketReference repository="" revision="46968"
 Date/Time: In `wp_insert_post()`, when checking the post date to set
 `future` or `publish` status, use a proper delta comparison.

 [3525] allowed a difference up to 59 seconds between the post date/time
 and the current time to consider the post published instead of scheduled,
 but that didn't take start of a new minute into account.

 Rapidly creating post fixtures in unit tests could encounter a one-second
 discrepancy between `current_time( 'mysql' )` and `gmdate( 'Y-m-d H:i:s'
 )`, returning values like `2019-12-16 23:43:00` vs. `2019-12-16 23:42:59`,
 respectively, and setting the post to a `future` status instead of
 `publish`.

 [45851], while working as intended, made the issue somewhat more likely to
 occur.

 This caused all sorts of occasional random failures in various tests on
 Travis, mostly on PHP 7.1.

 Fixes #48145.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/48145#comment:31>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform