[wp-trac] [WordPress Trac] #46456: Customize: widgets search shouldn't search by widgets id

[WordPress Trac]

#46456: Customize: widgets search shouldn't search by widgets id
---------------------------------------+---------------------
 Reporter:  afercia                    |       Owner:  (none)
     Type:  defect (bug)               |      Status:  new
 Priority:  normal                     |   Milestone:  5.4
Component:  Customize                  |     Version:  3.9
 Severity:  normal                     |  Resolution:
 Keywords:  has-screenshots has-patch  |     Focuses:  ui
---------------------------------------+---------------------
Changes (by dlh):

 * keywords:  has-screenshots => has-screenshots has-patch
 * milestone:  Awaiting Review => 5.4


Comment:

 I'm not sure a widget ID could be changed without backwards-compatibility
 considerations, but the given reasons generally make sense to me. The IDs-
 can't-be-translated screenshots seem persuasive by themselves.

 However, there's similar code in place for searching themes, which also
 considers the theme slug, or `id`. The slug support was added quite
 deliberately in #26730.

 I don't have the context to say whether ID support was added to widgets
 for parity with theme searches. But I could see an argument that site
 owners are somewhat more likely to come into contact with a theme slug
 than with the ID of a widget in the codebase, and so including IDs makes
 sense in one case but not the other.

 [attachment:"46456.diff"] is in that spirit. Perhaps a decision could be
 made on this suggestion for 5.4?

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/46456#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform