[wp-trac] [WordPress Trac] #33717: Send Notification Email When a Comment is Approved From Moderation

[WordPress Trac]

#33717: Send Notification Email When a Comment is Approved From Moderation
-------------------------------------------------+-------------------------
 Reporter:  jeffr0                               |       Owner:  swissspidy
     Type:  feature request                      |      Status:  assigned
 Priority:  normal                               |   Milestone:  Future
                                                 |  Release
Component:  Comments                             |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch needs-testing needs-unit-  |     Focuses:
  tests                                          |
-------------------------------------------------+-------------------------
Changes (by imath):

 * keywords:  has-patch has-unit-tests needs-testing => has-patch needs-
     testing needs-unit-tests


Comment:

 Hi @garrett-eclipse,

 Thanks for your feedback :)

 About 1) I thought about adding the checkbox to the comment form at the
 beginning. But I've changed my mind for 2 reasons :
 - I know some plugins are adding checkboxes there. For instance to be
 notified of new replies, so I felt adding too much checkboxes there was
 complexifying the form.
 - You're only sure the comment will be held for moderation if the site
 administrator has chosen to moderate manually each comment. If he chose
 the "Comment author must have a previously approved comment" option, then
 it's becoming more complex and requires an AJAX request to check if the
 user has not previously commented.

 I believe we should try to keep it as simple as possible and I think our
 options are :
 1. notify any user having their comment approved (previous patches),
 2. use a new form once the comment has been saved as pending to leave the
 choice to the comment author to be notified or not (my preference),
 3. do nothing :)

 About 2) Thanks a lot! I've fixed it in
 [https://core.trac.wordpress.org/attachment/ticket/33717/33717.12.diff
 33717.12.diff]

 About 3) Using a cookie would only avoid 1 click for the 2nd option, I'm
 not sure it saves the comment author so much time as he would need to
 submit the form anyway. But if we think it's absolutely required, then why
 not ;)

 About 4) I agree we need to make sure the form is notification opt-in form
 is not output if the site owner removed the hook that triggers the
 notification. In other words, using `remove_action(
 'comment_unapproved_to_approved', 'wp_new_comment_notify_comment_author'
 );` is disabling the feature. I think if we can avoid a new option into
 the Discussion settings, it's always better.
 [https://core.trac.wordpress.org/attachment/ticket/33717/33717.12.diff
 33717.12.diff] has been improved to handle this case.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/33717#comment:59>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform