[wp-trac] [WordPress Trac] #46128: Custom header "Hide image" button not displayed when randomizing images via theme setup

[WordPress Trac]

#46128: Custom header "Hide image" button not displayed when randomizing images via
theme setup
-------------------------------------+------------------------------
 Reporter:  webmandesign             |       Owner:  (none)
     Type:  defect (bug)             |      Status:  new
 Priority:  normal                   |   Milestone:  Awaiting Review
Component:  Customize                |     Version:  3.4
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |     Focuses:
-------------------------------------+------------------------------
Changes (by dlh):

 * keywords:   => has-patch needs-testing
 * focuses:  ui =>
 * version:  5.0.3 => 3.4


Comment:

 Hi @webmandesign, and (belated) thanks for this report.

 The custom header API is far from my expertise. But, by my reckoning, the
 `default` for the `header_image` setting needs to be modified so that it
 returns `random-default-image` when random header images are going to be
 used. [attachment:"46128.diff"] has that change. Would you be able to test
 the patch?

 From my reading of the code and testing, the patch should respect themes
 that set `random-image` to `false`.

 I don't ''think'' there needs to be a case where the `default` is `random-
 uploaded-image`, because `is_random_header_image()` won't return an
 uploaded image as a fallback, but my unfamiliarity could be misleading me
 about this point.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/46128#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform