[wp-trac] [WordPress Trac] #48933: Incorrect configuration value name in unit tests
WordPress Trac
noreply at wordpress.org
Wed Dec 11 11:26:51 UTC 2019
#48933: Incorrect configuration value name in unit tests
------------------------------+---------------------
Reporter: Rarst | Owner: (none)
Type: defect (bug) | Status: new
Priority: low | Milestone: 5.4
Component: Build/Test Tools | Version:
Severity: minor | Resolution:
Keywords: | Focuses:
------------------------------+---------------------
Changes (by SergeyBiryukov):
* milestone: Awaiting Review => 5.4
Comment:
Good catch! This was committed as `slowThreshold` in [35214], then
switched to `slow_threshold` in [45607] per the coding standards.
Either the option name change should be reverted (I think the coding
standards only apply to the variable name), or the option handling in
`SpeedTrapListener::loadOptions()` should be changed too.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/48933#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list