[wp-trac] [WordPress Trac] #48585: Color contrast changes impact color schemes negatively

[WordPress Trac]

#48585: Color contrast changes impact color schemes negatively
-------------------------------------------------+-------------------------
 Reporter:  Ate Up With Motor                    |       Owner:  audrasjb
     Type:  defect (bug)                         |      Status:  closed
 Priority:  normal                               |   Milestone:  5.3.1
Component:  Administration                       |     Version:  5.3
 Severity:  normal                               |  Resolution:  fixed
 Keywords:  has-screenshots 5-3-admin-css-       |     Focuses:  ui,
  changes has-patch commit needs-dev-note        |  accessibility
-------------------------------------------------+-------------------------

Comment (by ryelle):

 > This happens because the plugin still uses the color variable, as it is
 supposed to do. Instead, this change introduces a hardcoded color. No
 strong objections, though it goes a bit against the purpose of having
 color variables. If this is going to stay, it should be explained to
 plugin authors so they can use the new hardcoded color if they want.

 Not exactly– the issue is that the color scheme plugins (at least, this
 one), need to be keep up-to-date with core's sass files. I haven't kept on
 top of this for admin-color-schemes, so it's out of date. You can see it
 working correctly if you [https://github.com/ryelle/admin-color-schemes
 download it from github], as I've updated it there.

 These secondary buttons are not meant to be customizable, hence not using
 variables. The [https://make.wordpress.org/core/2019/12/10/alternate-
 color-schemes-changes-in-wordpress-5-3-1/ note posted today] explains all
 this well enough, I don't think any other notes are needed.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/48585#comment:29>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform