[wp-trac] [WordPress Trac] #48420: Admin CSS: standardize form controls heights, alignments, etc.

[WordPress Trac]

#48420: Admin CSS: standardize form controls heights, alignments, etc.
-------------------------------------------------+-------------------------
 Reporter:  afercia                              |       Owner:  audrasjb
     Type:  defect (bug)                         |      Status:  reopened
 Priority:  normal                               |   Milestone:  5.3.1
Component:  Administration                       |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  has-screenshots 5-3-admin-css-       |     Focuses:  ui
  changes needs-dev-note close                   |
-------------------------------------------------+-------------------------
Changes (by azaozz):

 * keywords:  has-screenshots 5-3-admin-css-changes needs-dev-note => has-
     screenshots 5-3-admin-css-changes needs-dev-note close
 * milestone:  5.4 => 5.3.1


Comment:

 Replying to [comment:35 afercia]:
 > If no objections, I'd like to propose to make this ticket a task
 > ...
 > The work on form controls improvements will need further iteration and
 I'm not sure creating a new ticket would be the best path forward.

 Don't think it is a good idea to mix many bugfuxes and enhancements on a
 single "enormous" ticket. This leads to confusion what was done and why,
 poor tracking of changes and reviews and ultimately leads to inconsistent
 tracking of changes and omissions.

 > - making the border radius consistent, see design feedback on comment:28
 > - standardize vertical alignment, see comment:20
 > - implement the 8 pixels based "grid" from

 The first is a pretty substantial bugfix that will require quite a bit of
 testing and reviews, mostly regarding the visual design.

 The second sounds like an enhancement that will need further
 testing/consideration. The `vertical-align: middle` may work for many
 browsers and in many cases, but doesn't work everywhere for everything.

 The third is a very large undertaking that will (probably) need a feature
 project in order to be completed properly. It will need a lot of
 iterating, testing and reviews as the potential to "break" existing layout
 seems large. Looks like it may even span over several releases.

 Thinking that "lumping all of this together" is a bad idea that will
 prevent proper development.

 Also, initially this ticket was for the 5.4 milestone. I was brought to
 the 5.3.1 milestone in an attempt to fix some of the CSS regressions
 introduced in 5.3. This is now complete and the ticket was closed. All
 remaining bugfixes, enhancements and new features should be moved to new
 tickets.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/48420#comment:38>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform