[wp-trac] [WordPress Trac] #48154: Build Tools: Integrate DependencyExtractionWebpackPlugin in the JS build
WordPress Trac
noreply at wordpress.org
Mon Dec 9 14:00:44 UTC 2019
#48154: Build Tools: Integrate DependencyExtractionWebpackPlugin in the JS build
------------------------------------+------------------------------
Reporter: gziolo | Owner: gziolo
Type: enhancement | Status: assigned
Priority: normal | Milestone: Awaiting Review
Component: Build/Test Tools | Version: trunk
Severity: normal | Resolution:
Keywords: has-patch dev-feedback | Focuses: javascript
------------------------------------+------------------------------
Comment (by netweb):
Replying to [comment:14 gziolo]:
> Good catch. I think I missed it. We can update it.
>
> > `svn:ignore`
>
> Yes, I copied the diff from GitHub. I will create next patch from svn.
It needs to be in both, the `svn:ignore` property and the `.gitignore`
> @netweb, thanks for leaving feedback. I think I need to clarify a few
things:
> - `grunt assets:move` depends on `grunt webpack:prod` and `grunt
webpack:dev`
> - `grunt copy:assets` is subtask of `grunt assets:move` so the issue is
the same
> - `/src/wp-includes/assets/dist` - this is the target for `npm run
build:dev`
> - `/build/wp-includes/assets/dist` - this is the target for `npm run
build`
>
> In general, this is very hard to tackle if we want to use PHP files
because webpack natively isn't flexible enough to easily allow moving
assets to a different folder.
Thanks, let me test that all again 👍🏼
--
Ticket URL: <https://core.trac.wordpress.org/ticket/48154#comment:15>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list