[wp-trac] [WordPress Trac] #48154: Build Tools: Integrate DependencyExtractionWebpackPlugin in the JS build

[WordPress Trac]

#48154: Build Tools: Integrate DependencyExtractionWebpackPlugin in the JS build
------------------------------------+------------------------------
 Reporter:  gziolo                  |       Owner:  gziolo
     Type:  enhancement             |      Status:  assigned
 Priority:  normal                  |   Milestone:  Awaiting Review
Component:  Build/Test Tools        |     Version:  trunk
 Severity:  normal                  |  Resolution:
 Keywords:  has-patch dev-feedback  |     Focuses:  javascript
------------------------------------+------------------------------

Comment (by netweb):

 Notes:

 - Prior to committing the `package-lock.json` file requires refreshing,
 otherwise patch applies cleanly:
 {{{
 patching file package-lock.json
 Hunk #35 FAILED at 6101.
 Hunk #36 FAILED at 6114.
 Hunk #37 FAILED at 6174.
 Hunk #39 FAILED at 7055.
 Hunk #53 FAILED at 8404.
 Hunk #79 FAILED at 17535.
 Hunk #82 FAILED at 18504.
 7 out of 95 hunks FAILED -- saving rejects to file package-lock.json.rej
 }}}

 - p.s No objections to sneaking in some `npm audit` fixes during commit
 either

 ----
 - The `svn:ignore` file also requires updating for the `/src/wp-
 includes/assets` path
 {{{
 svn propget svn:ignore
 # Configuration files with possibly sensitive information
 wp-config.php
 wp-tests-config.php
 .htaccess
 # Files and folders related to build/test tools
 phpunit.xml
 phpcs.xml
 .phpcs.xml
 node_modules
 npm-debug.log
 build
 wp-cli.local.yml
 .git
 jsdoc
 vendor
 docker-compose.override.yml
 }}}


 ----

 Grunt

 - The `clean:assets` task is not included in the parent `grunt clean`
 task, should it?

 - Based
 [https://core.trac.wordpress.org/attachment/ticket/48154/Screen%20Shot%202019-12-04%20at%2016.10.08.png
 on the image above] the `php` assets are now stored in the `/src/wp-
 includes/assets/dist` folder, added a comment to the GH PR
 [https://github.com/WordPress/wordpress-develop/pull/102/files#r355390037
 here]

 - Running either `grunt assets:move` or `grunt copy:assets` does not
 create a folder at `/src/wp-includes/assets` with the expected `dist`
 folder and `*.asset.php` files

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/48154#comment:13>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform