[wp-trac] [WordPress Trac] #48763: Twenty Twenty: SmoothScroll is broken

WordPress Trac noreply at wordpress.org
Sat Dec 7 11:03:21 UTC 2019


#48763: Twenty Twenty: SmoothScroll is broken
-------------------------------------+-------------------------------------
 Reporter:  joostdevalk              |       Owner:  audrasjb
     Type:  defect (bug)             |      Status:  closed
 Priority:  normal                   |   Milestone:  5.3.1
Component:  Bundled Theme            |     Version:  5.3
 Severity:  normal                   |  Resolution:  fixed
 Keywords:  has-patch has-           |     Focuses:  accessibility,
  screenshots needs-dev-note commit  |  javascript, css
-------------------------------------+-------------------------------------
Changes (by SergeyBiryukov):

 * status:  accepted => closed
 * resolution:   => fixed


Comment:

 In [changeset:"46824" 46824]:
 {{{
 #!CommitTicketReference repository="" revision="46824"
 Twenty Twenty: Replace Smooth Scroll JS implementation with `scroll-
 behavior` CSS property.

 The JS implementation had multiple issues and did not work as expected.

 This change includes an accessibility enhancement by using `prefers-
 reduced-motion: reduce` media query property for users that don't want
 motion effects. For further explanation on this media query, see MDN
 documentation: https://developer.mozilla.org/en-US/docs/Web/CSS/scroll-
 behavior#Accessibility_concerns

 Props audrasjb, melchoyce, joostdevalk, Anlino, mauteri, sergiomdgomes,
 littlebigthing, williampatton, netweb, andraganescu, joyously, acosmin,
 mukesh27, hareesh-pillai.
 Fixes #48763, #48551, #48866.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/48763#comment:25>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list