[wp-trac] [WordPress Trac] #42437: Thumbnails can overwrite other uploads if filename matches

[WordPress Trac]

#42437: Thumbnails can overwrite other uploads if filename matches
-------------------------------------------------+-------------------------
 Reporter:  Viper007Bond                         |       Owner:  pbiron
     Type:  defect (bug)                         |      Status:  assigned
 Priority:  normal                               |   Milestone:  5.3.1
Component:  Upload                               |     Version:  4.8.3
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch needs-testing needs-unit-  |     Focuses:
  tests                                          |
-------------------------------------------------+-------------------------

Comment (by pbiron):

 Replying to [comment:45 azaozz]:
 > In 42437.4.diff: same as 42437.3.diff but brings back adding a number to
 the file name when it matches the pattern or "reserved" file name endings.

 This seems to work great on all the tests I've run.  Will try to run some
 more tomorrow morning.

 Replying to [comment:46 azaozz]:
 > There's no good way to add "binary" files to diffs. If you upload the
 images here, I can add them separately when committing the tests (images
 should be copyright free/in "public domain").

 I was thinking of the color swatches that Alex already attached to this
 ticket (and maybe a few more like them).  But I won't have time to try to
 write additional tests until the weekend.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/42437#comment:47>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform