[wp-trac] [WordPress Trac] #42437: Thumbnails can overwrite other uploads if filename matches

[WordPress Trac]

#42437: Thumbnails can overwrite other uploads if filename matches
-------------------------------------------------+-------------------------
 Reporter:  Viper007Bond                         |       Owner:  pbiron
     Type:  defect (bug)                         |      Status:  assigned
 Priority:  normal                               |   Milestone:  5.3.1
Component:  Upload                               |     Version:  4.8.3
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch needs-testing needs-unit-  |     Focuses:
  tests                                          |
-------------------------------------------------+-------------------------

Comment (by pbiron):

 After a little bit of testing, it seems clear we have to do something for
 case 1, whether the "append a number" solution or something else.

 To see this, after applying 42437.3.diff do the following:

 1. verify that the size of "Thumbnail" to 150x150 (in ''Settings >
 Media'')
 2. upload ''image.jpg'' (that is larger than 150x150), this will create
 the sub-size ''image-150x150.jpg''
 3. upload ''image-140x140.jpg'' (this will create the sub-size ''image-
 140x140-150x150.jpg''
 4. change the size of "Thumbnail" to 140x140
 5. run `wp media regenerate` (or use the ''Regenerate Thumbnails'' or
 another plugin to do the same)

 After step 5, you'll see that the original of ''image-140x140.jpg'' has
 been overwritten by the thumbnail sub-size of ''image.jpg''.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/42437#comment:42>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform